Issue 195893030: Remove warnings from type mirrors and add argument checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195893030: Remove warnings from type mirrors and add argument checks. (Closed)

Created:
6 years, 9 months ago by karlklose

Modified:
6 years, 9 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove InstanceMirrorMixin from type mirrors and add argument checks in isSubclassOf. This makes dart2js/mirrors/relation_subclass_test pass in unchecked mode and removes warnings about a missing InstanceMirror.type from two implementation of TypeMirror. This CL also marks the exit_code_test as Skip, because it does not work in unchecked mode. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=33740

Patch Set 1 #

Patch Set 2 : Mark exit_code_test as Skip. #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart	View	1 2	2 chunks	+1 line, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_library_mirror.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/exit_code_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

6 years, 9 months ago (2014-03-17 12:22:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r33740 (presubmit successful).

Expand Messages | Collapse Messages