sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart - Issue 195893030: Remove warnings from type mirrors and add argument checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

Issue 195893030: Remove warnings from type mirrors and add argument checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_library_mirror.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

index 3d3b668a16de5b6ebf514e3509ac0222da1f4401..1ac23d02bd381b096acae89abe9e9d3f461d1a47 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

@@ -167,8 +167,7 @@ abstract class Dart2JsGenericTypeMirror extends Dart2JsTypeMirror {

class Dart2JsInterfaceTypeMirror

extends Dart2JsGenericTypeMirror

- with ObjectMirrorMixin, InstanceMirrorMixin, ClassMirrorMixin,

- ContainerMixin

+ with ObjectMirrorMixin, ClassMirrorMixin, ContainerMixin

implements ClassMirror {

Dart2JsInterfaceTypeMirror(Dart2JsMirrorSystem system,

InterfaceType interfaceType)

@@ -255,7 +254,7 @@ class Dart2JsClassDeclarationMirror

Dart2JsClassDeclarationMirror otherDeclaration =

other.originalDeclaration;

return _element.isSubclassOf(otherDeclaration._element);

- } else if (other is TypeMirror) {

+ } else if (other is FunctionTypeMirror) {

return false;

}

throw new ArgumentError(other);

@@ -351,8 +350,7 @@ class Dart2JsTypeVariableMirror extends Dart2JsTypeMirror

}

class Dart2JsFunctionTypeMirror extends Dart2JsTypeMirror

- with ObjectMirrorMixin, InstanceMirrorMixin,

- ClassMirrorMixin, DeclarationMixin

+ with ObjectMirrorMixin, ClassMirrorMixin, DeclarationMixin

implements FunctionTypeMirror {

final FunctionSignature _functionSignature;

List<ParameterMirror> _parameters;