Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 19500013: Use path package in dartdoc (Closed)

Created:
7 years, 5 months ago by dgrove
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, Andrei Mouravski, Anders Johnsen
Visibility:
Public.

Description

Use path package rather than Path from dart:io . R=ajohnsen@google.com, rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25316

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -82 lines) Patch
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 2 3 4 5 12 chunks +38 lines, -41 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/json_serializer.dart View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/dartdoc/test/dartdoc_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/apidoc.dart View 1 2 3 4 8 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrove
7 years, 5 months ago (2013-07-19 23:46:49 UTC) #1
Anders Johnsen
LGTM, thanks for doing this! https://codereview.chromium.org/19500013/diff/4001/utils/apidoc/apidoc.dart File utils/apidoc/apidoc.dart (right): https://codereview.chromium.org/19500013/diff/4001/utils/apidoc/apidoc.dart#newcode104 utils/apidoc/apidoc.dart:104: path.join(scriptDir, '..', '..', 'sdk', ...
7 years, 5 months ago (2013-07-22 04:38:30 UTC) #2
Bob Nystrom
One suggestion but LGTM. https://codereview.chromium.org/19500013/diff/4001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/19500013/diff/4001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode466 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:466: var p = _libraryPath(library); How ...
7 years, 5 months ago (2013-07-22 20:01:06 UTC) #3
dgrove
https://codereview.chromium.org/19500013/diff/4001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/19500013/diff/4001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode466 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:466: var p = _libraryPath(library); On 2013/07/22 20:01:06, Bob Nystrom ...
7 years, 5 months ago (2013-07-22 23:04:34 UTC) #4
dgrove
7 years, 5 months ago (2013-07-22 23:04:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r25316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698