Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart

Issue 19500013: Use path package in dartdoc (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/dartdoc/lib/dartdoc.dart ('k') | sdk/lib/_internal/dartdoc/lib/src/json_serializer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart
===================================================================
--- sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart (revision 25311)
+++ sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart (working copy)
@@ -24,9 +24,9 @@
* has been successfully compiled.
*/
// TODO(amouravski): Remove this method and call dart2js via a process instead.
-Future<String> compile(Path script,
- Path libraryRoot,
- {Path packageRoot,
+Future<String> compile(String script,
+ String libraryRoot,
+ {String packageRoot,
List<String> options: const <String>[],
api.DiagnosticHandler diagnosticHandler}) {
SourceFileProvider provider = new SourceFileProvider();
@@ -48,9 +48,9 @@
* Analyzes set of libraries and provides a mirror system which can be used for
* static inspection of the source code.
*/
-Future<MirrorSystem> analyze(List<Path> libraries,
- Path libraryRoot,
- {Path packageRoot,
+Future<MirrorSystem> analyze(List<String> libraries,
+ String libraryRoot,
+ {String packageRoot,
List<String> options: const <String>[],
api.DiagnosticHandler diagnosticHandler}) {
SourceFileProvider provider = new SourceFileProvider();
@@ -64,8 +64,8 @@
packageUri = currentDirectory.resolve(appendSlash('$packageRoot'));
}
List<Uri> librariesUri = <Uri>[];
- for (Path library in libraries) {
- librariesUri.add(currentDirectory.resolve(library.toString()));
+ for (String library in libraries) {
+ librariesUri.add(currentDirectory.resolve(library));
}
return dart2js.analyze(librariesUri, libraryUri, packageUri,
provider.readStringFromUri, diagnosticHandler,
« no previous file with comments | « sdk/lib/_internal/dartdoc/lib/dartdoc.dart ('k') | sdk/lib/_internal/dartdoc/lib/src/json_serializer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698