Fix a barback bug that triggered when an asset was removed.

Fix a barback bug that triggered when an asset was removed.

If a transform had that asset as its primary input, it would go into an error
state.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25116

[Bob Nystrom, 2013-07-17 17:18:26]

One suggestion. LGTM either way.

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/phase.dart
File pkg/barback/lib/src/phase.dart (right):

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/phase.dar...
pkg/barback/lib/src/phase.dart:157: new TransformOutputs(new AssetSet(),
transform.outputs));
Smart way to handle this. :)

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/transform...
File pkg/barback/lib/src/transform_node.dart (right):

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/transform...
pkg/barback/lib/src/transform_node.dart:46: Set<AssetId> get outputs =>
_outputs;
Instead of making this public, how about defining:

TransformOutputs removeAllOutputs() => new TransformOutputs(new AssetSet(),
_outputs);

[nweiz, 2013-07-17 18:29:55]

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/transform...
File pkg/barback/lib/src/transform_node.dart (right):

https://codereview.chromium.org/19473002/diff/1/pkg/barback/lib/src/transform...
pkg/barback/lib/src/transform_node.dart:46: Set<AssetId> get outputs =>
_outputs;
On 2013/07/17 17:18:26, Bob Nystrom wrote:
> Instead of making this public, how about defining:
> 
> TransformOutputs removeAllOutputs() => new TransformOutputs(new AssetSet(),
> _outputs);

I thought about that, but I couldn't come up with a name I was happy with and I
took that as a sign that that wasn't the right way to do it. For example,
[removeAllOutputs] sounds like it's a mutating operation that will remove
outputs, which isn't the case.

I'm not too worried about making [outputs] public; I think it and [inputs] will
both need to be public eventually to support more intelligence about what
transforms need to be waited for when requesting an asset.

[nweiz, 2013-07-17 18:32:17]

Committed patchset #1 manually as r25116 (presubmit successful).