Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: pkg/barback/test/package_graph/source_test.dart

Issue 19473002: Fix a barback bug that triggered when an asset was removed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/test/package_graph/source_test.dart
diff --git a/pkg/barback/test/package_graph/source_test.dart b/pkg/barback/test/package_graph/source_test.dart
index 0367d88ef4fe37f2a68848a40a3f30169788b69c..0185679954c9b3b99ce0b716dad038923c0f8f1a 100644
--- a/pkg/barback/test/package_graph/source_test.dart
+++ b/pkg/barback/test/package_graph/source_test.dart
@@ -17,6 +17,7 @@ main() {
initGraph(["app|foo.txt"]);
updateSources(["app|foo.txt"]);
expectAsset("app|foo.txt");
+ buildShouldSucceed();
});
test("doesn't get an unknown source", () {
@@ -49,6 +50,7 @@ main() {
updateSources(["app|foo.txt"]);
expectAsset("app|foo.txt");
+ buildShouldSucceed();
});
test("doesn't get a removed source", () {
@@ -56,12 +58,14 @@ main() {
updateSources(["app|foo.txt"]);
expectAsset("app|foo.txt");
+ buildShouldSucceed();
schedule(() {
removeSources(["app|foo.txt"]);
});
expectNoAsset("app|foo.txt");
+ buildShouldSucceed();
});
test("collapses redundant updates", () {
@@ -77,6 +81,7 @@ main() {
});
expectAsset("app|foo.blab", "foo.blab");
+ buildShouldSucceed();
schedule(() {
expect(transformer.numRuns, equals(1));
@@ -92,6 +97,7 @@ main() {
});
expectNoAsset("app|foo.txt");
+ buildShouldSucceed();
});
test("an update cancels out a removal", () {
@@ -103,6 +109,7 @@ main() {
});
expectAsset("app|foo.txt");
+ buildShouldSucceed();
});
test("restarts a build if a source is updated while sources are loading", () {

Powered by Google App Engine
This is Rietveld 408576698