Implement reflecting on static fields.

Implement reflecting on static fields.

BUG=http://dartbug.com/11745
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25086

[ngeoffray, 2013-07-17 07:41:11]

LGTM

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
(right):

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1896: void
forEachStaticField(void f(ClassElement enclosingClass, Element field)) {
Does the user of this function care of the enclosing class? Isn't it always
"this" since you're not asking for super fields?

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3537:
js('init.mangledGlobalNames = #', map).toStatement(), compiler));
long line

[ahe, 2013-07-17 08:39:15]

Thank you, Nicolas.

I'm submitting now, but I found a few issues while testing, these are recorded
in patch set #2. I'd appreciate if you could go over that patch set at your
convenience.

Cheers,
Peter

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
(right):

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1896: void
forEachStaticField(void f(ClassElement enclosingClass, Element field)) {
On 2013/07/17 07:41:11, ngeoffray wrote:
> Does the user of this function care of the enclosing class? Isn't it always
> "this" since you're not asking for super fields?

Yes, but since it is used analogous to forEachInstanceField and forEachMember,
it is really helpful that they are compatible.

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/19405002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3537:
js('init.mangledGlobalNames = #', map).toStatement(), compiler));
On 2013/07/17 07:41:11, ngeoffray wrote:
> long line

Done.

[ahe, 2013-07-17 08:40:49]

Committed patchset #3 manually as r25086 (presubmit successful).

[ngeoffray, 2013-07-17 08:43:20]

Still LGTM