dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 19405002: Implement reflecting on static fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 19405002: Implement reflecting on static fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix a long line. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

index ebdb9fda2db9cd1ab958a8ac8129e490e0e127dd..a0f3d01c61ba4b8f20c72ea888eebd94663c8a05 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

@@ -37,7 +37,8 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

bool emitClassFields(ClassElement classElement,

ClassBuilder builder,

String superName,

- { bool classIsNative: false }) {

+ { bool classIsNative: false,

+ bool emitStatics: false }) {

// Class fields are dynamically generated so they have to be

// emitted using getters and setters instead.

return false;

@@ -53,12 +54,13 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

// get$d : function() { return this.d; }

// set$d : function(x) { this.d = x; }

List<String> fields = <String>[];

- visitClassFields(classElement, (Element member,

- String name,

- String accessorName,

- bool needsGetter,

- bool needsSetter,

- bool needsCheckedSetter) {

+ visitClassFields(classElement, false,

+ (Element member,

+ String name,

+ String accessorName,

+ bool needsGetter,

+ bool needsSetter,

+ bool needsCheckedSetter) {

fields.add(name);

});

String constructorName = namer.safeName(classElement.name.slowToString());