Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 19332003: Fix crash https://code.google.com/p/dart/issues/detail?id=11724: check for erroneous before asking … (Closed)

Created:
7 years, 5 months ago by ngeoffray
Modified:
7 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix crash https://code.google.com/p/dart/issues/detail?id=11724: check for erroneous before asking for the signature of an element. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/container_tracer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/issue11724_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 5 months ago (2013-07-16 07:41:33 UTC) #1
karlklose
LGTM.
7 years, 5 months ago (2013-07-16 07:49:05 UTC) #2
ngeoffray
7 years, 5 months ago (2013-07-16 09:08:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698