Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: sdk/lib/_internal/compiler/implementation/types/container_tracer.dart

Issue 19332003: Fix crash https://code.google.com/p/dart/issues/detail?id=11724: check for erroneous before asking … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/issue11724_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/types/container_tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/types/container_tracer.dart (revision 25009)
+++ sdk/lib/_internal/compiler/implementation/types/container_tracer.dart (working copy)
@@ -306,6 +306,8 @@
if (!indices.isEmpty) {
Iterable<Element> callees;
if (callee is Element) {
+ // No need to go further, we know the call will throw.
+ if (callee.isErroneous()) return false;
callees = [callee];
} else {
assert(callee is Selector);
« no previous file with comments | « no previous file | tests/language/issue11724_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698