Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 19287003: Use proper internal name for implicit static final getters. (Closed)

Created:
7 years, 5 months ago by regis
Modified:
7 years, 5 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use proper internal name for implicit static final getters. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=25053

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M runtime/vm/ast.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 11 chunks +17 lines, -19 lines 0 comments Download
M runtime/vm/raw_object.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
Just removing a TODO by renaming some internal names.
7 years, 5 months ago (2013-07-15 23:28:04 UTC) #1
hausner
LGTM.
7 years, 5 months ago (2013-07-16 01:32:55 UTC) #2
regis
Thanks!
7 years, 5 months ago (2013-07-16 16:26:38 UTC) #3
regis
7 years, 5 months ago (2013-07-16 16:30:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698