Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1987)

Side by Side Diff: runtime/vm/mirrors_api_impl.cc

Issue 19287003: Use proper internal name for implicit static final getters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_mirrors_api.h" 5 #include "include/dart_mirrors_api.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/class_finalizer.h" 8 #include "vm/class_finalizer.h"
9 #include "vm/dart.h" 9 #include "vm/dart.h"
10 #include "vm/dart_api_impl.h" 10 #include "vm/dart_api_impl.h"
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 const Array& func_array = Array::Handle(cls.functions()); 254 const Array& func_array = Array::Handle(cls.functions());
255 255
256 // Some special types like 'dynamic' have a null functions list. 256 // Some special types like 'dynamic' have a null functions list.
257 if (!func_array.IsNull()) { 257 if (!func_array.IsNull()) {
258 for (intptr_t i = 0; i < func_array.Length(); ++i) { 258 for (intptr_t i = 0; i < func_array.Length(); ++i) {
259 func ^= func_array.At(i); 259 func ^= func_array.At(i);
260 260
261 // Skip implicit getters and setters. 261 // Skip implicit getters and setters.
262 if (func.kind() == RawFunction::kImplicitGetter || 262 if (func.kind() == RawFunction::kImplicitGetter ||
263 func.kind() == RawFunction::kImplicitSetter || 263 func.kind() == RawFunction::kImplicitSetter ||
264 func.kind() == RawFunction::kConstImplicitGetter || 264 func.kind() == RawFunction::kImplicitStaticFinalGetter ||
265 func.kind() == RawFunction::kMethodExtractor || 265 func.kind() == RawFunction::kMethodExtractor ||
266 func.kind() == RawFunction::kNoSuchMethodDispatcher) { 266 func.kind() == RawFunction::kNoSuchMethodDispatcher) {
267 continue; 267 continue;
268 } 268 }
269 269
270 name = func.UserVisibleName(); 270 name = func.UserVisibleName();
271 names.Add(name); 271 names.Add(name);
272 } 272 }
273 } 273 }
274 } else if (obj.IsLibrary()) { 274 } else if (obj.IsLibrary()) {
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 } else if (obj.IsField()) { 917 } else if (obj.IsField()) {
918 cls = Field::Cast(obj).origin(); 918 cls = Field::Cast(obj).origin();
919 } else { 919 } else {
920 return Api::NewHandle(isolate, Object::empty_array().raw()); 920 return Api::NewHandle(isolate, Object::empty_array().raw());
921 } 921 }
922 const Library& lib = Library::Handle(cls.library()); 922 const Library& lib = Library::Handle(cls.library());
923 return Api::NewHandle(isolate, lib.GetMetadata(obj)); 923 return Api::NewHandle(isolate, lib.GetMetadata(obj));
924 } 924 }
925 925
926 } // namespace dart 926 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698