Issue 191743002: Replace RoundMicrosecondsTo* utility.

Issue 191743002: Replace RoundMicrosecondsTo* utility. (Closed)

Created:
6 years, 9 months ago by koda

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Replace RoundMicrosecondsTo* with non-rounding MicrosecondsTo*. (The existing function didn't actually round, it just incorrectly added 0.5.) BUG=dart:17348 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33527

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
M	runtime/platform/globals.h	View	1 2 3	1 chunk	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Good find. Thanks! -Ivan https://codereview.chromium.org/191743002/diff/20001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/191743002/diff/20001/runtime/platform/globals.h#newcode329 runtime/platform/globals.h:329: inline int64_t RoundMicrosecondsToSeconds(int64_t micros) { ...

6 years, 9 months ago (2014-03-10 13:00:36 UTC) #2

koda

On 2014/03/10 13:00:36, Ivan Posva wrote: > Good find. Thanks! > > -Ivan > > ...

6 years, 9 months ago (2014-03-10 23:56:37 UTC) #3

koda

6 years, 9 months ago (2014-03-11 14:12:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r33527 (presubmit successful).

Expand Messages | Collapse Messages