Replace RoundMicrosecondsTo* utility.

runtime/platform/globals.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_GLOBALS_H_
 #define PLATFORM_GLOBALS_H_
 
 // __STDC_FORMAT_MACROS has to be defined before including <inttypes.h> to
 // enable platform independent printf format specifiers.
 #ifndef __STDC_FORMAT_MACROS
@@ skipping 308 matching lines @@
 const int kMicrosecondsPerMillisecond = 1000;
 const int kMicrosecondsPerSecond = (kMicrosecondsPerMillisecond *
                                     kMillisecondsPerSecond);
 const int kNanosecondsPerMicrosecond = 1000;
 const int kNanosecondsPerMillisecond = (kNanosecondsPerMicrosecond *
                                         kMicrosecondsPerMillisecond);
 const int kNanosecondsPerSecond = (kNanosecondsPerMicrosecond *
                                    kMicrosecondsPerSecond);
 
 // Helpers to round micro second times to human understandable values.
-inline double RoundMicrosecondsToSeconds(int64_t micros) {
+inline int64_t RoundMicrosecondsToSeconds(int64_t micros) {

[Ivan Posva, 2014/03/10 13:00:36]

We should keep these as double and drop the rounding. It was an error trying to
round after deciding to use doubles.

   const int k1M = 1000000;  // Converting us to secs.
-  return static_cast<double>(micros + (k1M >> 1)) / k1M;
+  return (micros + (k1M >> 1)) / k1M;
 }
-inline double RoundMicrosecondsToMilliseconds(int64_t micros) {
-  const int k1K = 1000;  // Conversting us to ms.
-  return static_cast<double>(micros + (k1K >> 1)) / k1K;
+inline int64_t RoundMicrosecondsToMilliseconds(int64_t micros) {

[Ivan Posva, 2014/03/10 13:00:36]

ditto.

+  const int k1K = 1000;  // Converting us to ms.
+  return (micros + (k1K >> 1)) / k1K;
 }
 
 // A macro to disallow the copy constructor and operator= functions.
 // This should be used in the private: declarations for a class.
 #define DISALLOW_COPY_AND_ASSIGN(TypeName)                                     \
 private:                                                                       \
   TypeName(const TypeName&);                                                   \
   void operator=(const TypeName&)
 
 
@@ skipping 154 matching lines @@
 // N.B.: As the GCC manual states, "[s]ince non-static C++ methods
 // have an implicit 'this' argument, the arguments of such methods
 // should be counted from two, not one."
 #define PRINTF_ATTRIBUTE(string_index, first_to_check) \
   __attribute__((__format__(__printf__, string_index, first_to_check)))
 #else
 #define PRINTF_ATTRIBUTE(string_index, first_to_check)
 #endif
 
 #endif  // PLATFORM_GLOBALS_H_