Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 191423002: [polymer] remove bogus warning about JS inline scripts (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, dgrove
Visibility:
Public.

Description

[polymer] remove bogus warning about JS inline scripts R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=33460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M pkg/polymer/lib/src/build/linter.dart View 1 chunk +2 lines, -20 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
We knew this warning had to go. Now is the time :)
6 years, 9 months ago (2014-03-07 20:10:05 UTC) #1
dgrove
lgtm
6 years, 9 months ago (2014-03-07 20:13:41 UTC) #2
Jennifer Messerly
Committed patchset #1 manually as r33460 (presubmit successful).
6 years, 9 months ago (2014-03-07 21:46:35 UTC) #3
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-10 17:42:59 UTC) #4
Message was sent while issue was closed.
lgtm!

Powered by Google App Engine
This is Rietveld 408576698