Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: pkg/polymer/test/build/linter_test.dart

Issue 191423002: [polymer] remove bogus warning about JS inline scripts (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library polymer.test.linter_test; 5 library polymer.test.linter_test;
6 6
7 import 'package:polymer/src/build/common.dart'; 7 import 'package:polymer/src/build/common.dart';
8 import 'package:polymer/src/build/linter.dart'; 8 import 'package:polymer/src/build/linter.dart';
9 import 'package:unittest/compact_vm_config.dart'; 9 import 'package:unittest/compact_vm_config.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 </polymer-element> 249 </polymer-element>
250 </html>'''.replaceAll(' ', ''), 250 </html>'''.replaceAll(' ', ''),
251 }, []); 251 }, []);
252 252
253 _testLinter('in polymer-element, inlined', { 253 _testLinter('in polymer-element, inlined', {
254 'a|lib/test.html': '''<html> 254 'a|lib/test.html': '''<html>
255 <polymer-element name="x-a"> 255 <polymer-element name="x-a">
256 <script>foo...</script> 256 <script>foo...</script>
257 </polymer-element> 257 </polymer-element>
258 </html>'''.replaceAll(' ', ''), 258 </html>'''.replaceAll(' ', ''),
259 }, [ 259 }, []);
260 'warning: script tag in polymer element with no type will '
261 'be treated as JavaScript. Did you forget type="application/dart"?'
262 ' (lib/test.html 2 0)'
263 ]);
264 260
265 _testLinter('top-level, dart type & .dart url', { 261 _testLinter('top-level, dart type & .dart url', {
266 'a|lib/test.html': '''<html> 262 'a|lib/test.html': '''<html>
267 <script type="application/dart" src="foo.dart"></script> 263 <script type="application/dart" src="foo.dart"></script>
268 </html>'''.replaceAll(' ', ''), 264 </html>'''.replaceAll(' ', ''),
269 }, []); 265 }, []);
270 266
271 _testLinter('top-level, dart type & .js url', { 267 _testLinter('top-level, dart type & .js url', {
272 'a|lib/test.html': '''<html> 268 'a|lib/test.html': '''<html>
273 <script type="application/dart" src="foo.js"></script> 269 <script type="application/dart" src="foo.js"></script>
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 '''.replaceAll(' ', ''), 456 '''.replaceAll(' ', ''),
461 }, []); 457 }, []);
462 } 458 }
463 459
464 _testLinter(String name, Map inputFiles, List outputMessages) { 460 _testLinter(String name, Map inputFiles, List outputMessages) {
465 var linter = new Linter(new TransformOptions()); 461 var linter = new Linter(new TransformOptions());
466 var outputFiles = {}; 462 var outputFiles = {};
467 inputFiles.forEach((k, v) => outputFiles[k] = v); 463 inputFiles.forEach((k, v) => outputFiles[k] = v);
468 testPhases(name, [[linter]], inputFiles, outputFiles, outputMessages); 464 testPhases(name, [[linter]], inputFiles, outputFiles, outputMessages);
469 } 465 }
OLDNEW
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698