Issue 189803004: Translate private Java members to private Dart members.

Issue 189803004: Translate private Java members to private Dart members. (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Translate private Java members to private Dart members. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33453

Patch Set 2 : Tweaks #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6696 lines, -6601 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java	View	1	2 chunks	+14 lines, -14 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java	View	1	6 chunks	+54 lines, -54 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/resources/test_support_include.dart	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java	View	1	2 chunks	+22 lines, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java	View	1	6 chunks	+17 lines, -9 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1	6 chunks	+21 lines, -18 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java	View	1	4 chunks	+19 lines, -23 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/JavaUtils.java	View	1	2 chunks	+38 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java	View	1	69 chunks	+190 lines, -141 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/BeautifySemanticProcessorTest.java	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/CollectionSemanticProcessorTest.java	View	1	14 chunks	+17 lines, -17 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/DateSemanticProcessorTest.java	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/GuavaSemanticProcessorTest.java	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/LoggerSemanticProcessorTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/MathSemanticProcessorTest.java	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java	View	1	10 chunks	+11 lines, -11 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/TypeSemanticProcessorTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	1	74 chunks	+562 lines, -562 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/constant.dart	View	1	57 chunks	+109 lines, -109 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	1	58 chunks	+78 lines, -78 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	1	250 chunks	+490 lines, -490 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/html.dart	View	1	36 chunks	+77 lines, -77 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/index.dart	View	1	69 chunks	+130 lines, -130 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	1	369 chunks	+1781 lines, -1579 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1	761 chunks	+1463 lines, -1463 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/scanner.dart	View	1	50 chunks	+242 lines, -227 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/sdk_io.dart	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_collection.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_dart.dart	View	1	1 chunk	+2 lines, -11 lines	0 comments	Download
M	pkg/analyzer/lib/src/services/formatter_impl.dart	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	1	13 chunks	+316 lines, -316 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	1	21 chunks	+137 lines, -328 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View		238 chunks	+568 lines, -568 lines	0 comments	Download
M	pkg/analyzer/test/generated/scanner_test.dart	View	1	35 chunks	+255 lines, -255 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	1	10 chunks	+12 lines, -40 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

https://codereview.chromium.org/189803004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/189803004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode109 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:109: private boolean inSwitch = false; I prefer the spacing ...

6 years, 9 months ago (2014-03-07 19:07:00 UTC) #2

scheglov

PTAL https://codereview.chromium.org/189803004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/189803004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode109 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:109: private boolean inSwitch = false; On 2014/03/07 19:07:01, ...

6 years, 9 months ago (2014-03-07 19:50:52 UTC) #3

scheglov

6 years, 9 months ago (2014-03-07 21:00:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33453 (presubmit successful).

Expand Messages | Collapse Messages