Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

Issue 189803004: Translate private Java members to private Dart members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweaks Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java
diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java
index 9c83b0c68fe60e85db0ebf3fa47d9da31cd552a9..5f4648cb4f4effc490123d351dc54503864b6e55 100644
--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java
+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java
@@ -796,13 +796,13 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {
@Override
public boolean visit(org.eclipse.jdt.core.dom.FieldDeclaration node) {
- boolean isPublic = org.eclipse.jdt.core.dom.Modifier.isPublic(node.getModifiers());
+ boolean isPrivate = JavaUtils.isPrivate(node) || JavaUtils.isPackagePrivate(node);
boolean isStatic = org.eclipse.jdt.core.dom.Modifier.isStatic(node.getModifiers());
boolean isFinal = false;
// interface field
org.eclipse.jdt.core.dom.ASTNode parent = node.getParent();
if (parent instanceof TypeDeclaration && ((TypeDeclaration) parent).isInterface()) {
- isPublic = true;
+ isPrivate = false;
isStatic = true;
isFinal = true;
}
@@ -811,7 +811,7 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {
translateJavadoc(node),
isStatic,
translateVariableDeclarationList(isFinal, node.getType(), node.fragments()));
- if (!isPublic) {
+ if (isPrivate) {
context.putPrivateClassMember(fieldDeclaration);
}
return done(fieldDeclaration);
@@ -971,7 +971,7 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {
@Override
public boolean visit(org.eclipse.jdt.core.dom.MethodDeclaration node) {
- boolean isPublic = org.eclipse.jdt.core.dom.Modifier.isPublic(node.getModifiers());
+ boolean isPrivate = JavaUtils.isPrivate(node) || JavaUtils.isPackagePrivate(node);
IMethodBinding binding = node.resolveBinding();
// parameters
FormalParameterList parameterList = translateMethodDeclarationParameters(node);
@@ -1016,7 +1016,7 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {
parameterList,
body);
context.putNodeBinding(methodDeclaration, binding);
- if (!isPublic) {
+ if (isPrivate) {
context.putPrivateClassMember(methodDeclaration);
}
return done(methodDeclaration);

Powered by Google App Engine
This is Rietveld 408576698