Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890853003: Add support for sharding test runs. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -2 lines) Patch
M lib/src/runner.dart View 1 3 chunks +25 lines, -2 lines 0 comments Download
M lib/src/runner/configuration.dart View 8 chunks +41 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 3 chunks +22 lines, -0 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 8 chunks +16 lines, -0 lines 0 comments Download
A test/runner/shard_test.dart View 1 chunk +169 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 8 months ago (2016-04-14 21:27:23 UTC) #1
kevmoo
LGTM - with nits https://codereview.chromium.org/1890853003/diff/1/lib/src/runner.dart File lib/src/runner.dart (right): https://codereview.chromium.org/1890853003/diff/1/lib/src/runner.dart#newcode6 lib/src/runner.dart:6: import 'dart:convert'; many unused imports ...
4 years, 8 months ago (2016-04-14 22:50:36 UTC) #2
nweiz
Code review changes
4 years, 8 months ago (2016-04-22 21:30:46 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as c2b2d0557c1bea76497bf4c2b478a5d89df92e59 (presubmit successful).
4 years, 8 months ago (2016-04-22 21:30:52 UTC) #5
nweiz
4 years, 8 months ago (2016-04-22 21:30:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1890853003/diff/1/lib/src/runner.dart
File lib/src/runner.dart (right):

https://codereview.chromium.org/1890853003/diff/1/lib/src/runner.dart#newcode350
lib/src/runner.dart:350: void _shardSuite(Suite suite) {
On 2016/04/14 22:50:36, kevmoo wrote:
> Suppose to return a Suite, no? Not void...

Done.

https://codereview.chromium.org/1890853003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1890853003/diff/1/pubspec.yaml#newcode15
pubspec.yaml:15: crypto: '>=0.9.2 <2.0.0'
On 2016/04/14 22:50:36, kevmoo wrote:
> not really used, it seems

Done.

Powered by Google App Engine
This is Rietveld 408576698