Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: test/runner/configuration/configuration_test.dart

Issue 1890853003: Add support for sharding test runs. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration/args.dart ('k') | test/runner/shard_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/configuration/configuration_test.dart
diff --git a/test/runner/configuration/configuration_test.dart b/test/runner/configuration/configuration_test.dart
index 72b9834cf251eaa08dd415df94765c70d140e28a..cb0e0e0cfc7b635cd7ddb9a3e820ef317290978a 100644
--- a/test/runner/configuration/configuration_test.dart
+++ b/test/runner/configuration/configuration_test.dart
@@ -27,6 +27,8 @@ void main() {
expect(merged.skipReason, isNull);
expect(merged.pauseAfterLoad, isFalse);
expect(merged.color, equals(canUseSpecialChars));
+ expect(merged.shardIndex, isNull);
+ expect(merged.totalShards, isNull);
expect(merged.packageRoot, equals(p.join(p.current, 'packages')));
expect(merged.reporter, equals(defaultReporter));
expect(merged.pubServeUrl, isNull);
@@ -44,6 +46,8 @@ void main() {
skipReason: "boop",
pauseAfterLoad: true,
color: true,
+ shardIndex: 3,
+ totalShards: 10,
packageRoot: "root",
reporter: "json",
pubServePort: 1234,
@@ -59,6 +63,8 @@ void main() {
expect(merged.skipReason, equals("boop"));
expect(merged.pauseAfterLoad, isTrue);
expect(merged.color, isTrue);
+ expect(merged.shardIndex, equals(3));
+ expect(merged.totalShards, equals(10));
expect(merged.packageRoot, equals("root"));
expect(merged.reporter, equals("json"));
expect(merged.pubServeUrl.port, equals(1234));
@@ -76,6 +82,8 @@ void main() {
skipReason: "boop",
pauseAfterLoad: true,
color: true,
+ shardIndex: 3,
+ totalShards: 10,
packageRoot: "root",
reporter: "json",
pubServePort: 1234,
@@ -90,6 +98,8 @@ void main() {
expect(merged.skipReason, equals("boop"));
expect(merged.pauseAfterLoad, isTrue);
expect(merged.color, isTrue);
+ expect(merged.shardIndex, equals(3));
+ expect(merged.totalShards, equals(10));
expect(merged.packageRoot, equals("root"));
expect(merged.reporter, equals("json"));
expect(merged.pubServeUrl.port, equals(1234));
@@ -108,6 +118,8 @@ void main() {
skipReason: "foo",
pauseAfterLoad: true,
color: false,
+ shardIndex: 2,
+ totalShards: 4,
packageRoot: "root",
reporter: "json",
pubServePort: 1234,
@@ -122,6 +134,8 @@ void main() {
skipReason: "bar",
pauseAfterLoad: false,
color: true,
+ shardIndex: 3,
+ totalShards: 10,
packageRoot: "boot",
reporter: "compact",
pubServePort: 5678,
@@ -136,6 +150,8 @@ void main() {
expect(merged.skipReason, equals("bar"));
expect(merged.pauseAfterLoad, isFalse);
expect(merged.color, isTrue);
+ expect(merged.shardIndex, equals(3));
+ expect(merged.totalShards, equals(10));
expect(merged.packageRoot, equals("boot"));
expect(merged.reporter, equals("compact"));
expect(merged.pubServeUrl.port, equals(5678));
« no previous file with comments | « lib/src/runner/configuration/args.dart ('k') | test/runner/shard_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698