Tweak unittest compact config a bit and don't use it on bots.

Tweak unittest compact config a bit and don't use it on bots.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24924

[Siggi Cherem (dart-lang), 2013-07-11 00:26:31]

awesome, thanks Bob! 

just a couple comments below

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:65: if (_runningOnBuildbot)
super.onDone(success);
we should at least exit with an appropriate exit code, and include what the
VMConfiguration does (wait for stout and stderr to be fully pinted out before
exiting).

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:190: if
(Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) {
if we don't set it altogether in the build bots, do we still need the checks
above (_runningOnBuildbot)?

[Bob Nystrom, 2013-07-11 16:42:14]

Thanks! Sorry I rushed this patch a bit. Should be better now.

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:65: if (_runningOnBuildbot)
super.onDone(success);
On 2013/07/11 00:26:31, Siggi Cherem (dart-lang) wrote:
> we should at least exit with an appropriate exit code, and include what the
> VMConfiguration does (wait for stout and stderr to be fully pinted out before
> exiting).

Done.

https://codereview.chromium.org/18811008/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:190: if
(Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) {
On 2013/07/11 00:26:31, Siggi Cherem (dart-lang) wrote:
> if we don't set it altogether in the build bots, do we still need the checks
> above (_runningOnBuildbot)?

Oh, no. That was old stale code. Removed.

[Siggi Cherem (dart-lang), 2013-07-11 16:47:40]

lgtm!

https://codereview.chromium.org/18811008/diff/5001/pkg/unittest/lib/compact_v...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/18811008/diff/5001/pkg/unittest/lib/compact_v...
pkg/unittest/lib/compact_vm_config.dart:64: // Override and don't call the
superclass onInit() to avoid printing the
onInit => onDone

[Bob Nystrom, 2013-07-11 18:35:00]

Committed patchset #3 manually as r24924 (presubmit successful).

[Bob Nystrom, 2013-07-11 18:35:16]

Thanks!

https://codereview.chromium.org/18811008/diff/5001/pkg/unittest/lib/compact_v...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/18811008/diff/5001/pkg/unittest/lib/compact_v...
pkg/unittest/lib/compact_vm_config.dart:64: // Override and don't call the
superclass onInit() to avoid printing the
On 2013/07/11 16:47:40, Siggi Cherem (dart-lang) wrote:
> onInit => onDone

Done.