Tweak unittest compact config a bit and don't use it on bots.

pkg/unittest/lib/compact_vm_config.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A test configuration that generates a compact 1-line progress bar. The bar is
  * updated in-place before and after each test is executed. If all test pass,
  * you should only see a couple lines in the terminal. If a test fails, the
  * failure is shown and the progress bar continues to be updated below it.
  */
 library compact_vm_config;
 
 import 'dart:io';
 import 'unittest.dart';
 import 'vm_config.dart';
 
 const String _GREEN = '\u001b[32m';
 const String _RED = '\u001b[31m';
 const String _NONE = '\u001b[0m';
+
 const int MAX_LINE = 80;
 
 class CompactVMConfiguration extends VMConfiguration {
   DateTime _start;
   int _pass = 0;
   int _fail = 0;
 
   void onInit() {
-    super.onInit();
+    // On the bots, we need to output the "unittest-suite-..."
+    // boilerplate that the bots look for. On local machines, don't print it.
+    if (_runningOnBuildbot) super.onInit();
   }
 
   void onStart() {
-    super.onStart();
     _start = new DateTime.now();
   }
 
   void onTestStart(TestCase test) {
     super.onTestStart(test);
     _progressLine(_start, _pass, _fail, test.description);
   }
 
   void onTestResult(TestCase test) {
     super.onTestResult(test);
     if (test.result == PASS) {
       _pass++;
       _progressLine(_start, _pass, _fail, test.description);
     } else {
       _fail++;
       _progressLine(_start, _pass, _fail, test.description);
       print('');
       if (test.message != '') {
         print(_indent(test.message));
       }
 
       if (test.stackTrace != null && test.stackTrace != '') {
         print(_indent(test.stackTrace));
       }
     }
   }
 
+  void onDone(bool success) {
+    // On the bots, we need to output the "unittest-suite-..."
+    // boilerplate that the bots look for. On local machines, don't print it.
+    if (_runningOnBuildbot) super.onDone(success);

[Siggi Cherem (dart-lang), 2013/07/11 00:26:31]

we should at least exit with an appropriate exit code, and include what the
VMConfiguration does (wait for stout and stderr to be fully pinted out before
exiting).

[Bob Nystrom, 2013/07/11 16:42:15]

Done.

+  }
+
   String _indent(String str) {
     return str.split("\n").map((line) => "  $line").join("\n");
   }
 
+  /// Returns whether we're running on a Dart build bot.
+  bool get _runningOnBuildbot =>
+      Platform.environment.containsKey('BUILDBOT_BUILDERNAME');
+
   void onSummary(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
     var success = false;
     if (passed == 0 && failed == 0 && errors == 0 && uncaughtError == null) {
       print('\nNo tests ran.');
     } else if (failed == 0 && errors == 0 && uncaughtError == null) {
-      _progressLine(_start, _pass, _fail, 'All tests pass', _GREEN);
-      print('\nAll $passed tests passed.');
+      _progressLine(_start, _pass, _fail, 'All tests passed!', _NONE);
+      print('');
       success = true;
     } else {
-      _progressLine(_start, _pass, _fail, 'Some tests fail', _RED);
+      _progressLine(_start, _pass, _fail, 'Some tests failed.', _RED);
       print('');
       if (uncaughtError != null) {
         print('Top-level uncaught error: $uncaughtError');
       }
       print('$passed PASSED, $failed FAILED, $errors ERRORS');
     }
   }
 
   int _lastLength = 0;
 
   final int _nonVisiblePrefix = 1 + _GREEN.length + _NONE.length;
 
   void _progressLine(DateTime startTime, int passed, int failed, String message,
       [String color = _NONE]) {
     var duration = (new DateTime.now()).difference(startTime);
     var buffer = new StringBuffer();
     // \r moves back to the beginning of the current line.
     buffer.write('\r${_timeString(duration)} ');
     buffer.write(_GREEN);
     buffer.write('+');
     buffer.write(passed);
     buffer.write(_NONE);
-    if (failed != 0) buffer.write(_RED);
-    buffer.write(' -');
-    buffer.write(failed);
-    if (failed != 0) buffer.write(_NONE);
+    if (failed != 0) {
+      buffer.write(_RED);
+      buffer.write(' -');
+      buffer.write(failed);
+      buffer.write(_NONE);
+    }
     buffer.write(': ');
     buffer.write(color);
 
     // Ensure the line fits under MAX_LINE. [buffer] includes the color escape
     // sequences too. Because these sequences are not visible characters, we
     // make sure they are not counted towards the limit.
     int nonVisible = _nonVisiblePrefix + color.length  +
         (failed != 0 ? (_RED.length + _NONE.length) : 0);
     int len = buffer.length - nonVisible;
     var mx = MAX_LINE - len;
@@ skipping 53 matching lines @@
     var res = text.substring(text.length - maxLength + 4);
     var firstSpace = res.indexOf(' ');
     if (firstSpace > 0) {
       res = res.substring(firstSpace);
     }
     return '...$res';
   }
 }
 
 void useCompactVMConfiguration() {
+  // If the test is running on the Dart buildbots, we don't want to use this
+  // config since it's output may not be what the bots expect.
+  if (Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) {

[Siggi Cherem (dart-lang), 2013/07/11 00:26:31]

if we don't set it altogether in the build bots, do we still need the checks
above (_runningOnBuildbot)?

[Bob Nystrom, 2013/07/11 16:42:15]

Oh, no. That was old stale code. Removed.

+    return;
+  }
+
   unittestConfiguration = _singleton;
 }
 
 final _singleton = new CompactVMConfiguration();