Fixing CustomEvent.detail leaks.

Fixing CustomEvent.detail leaks.

Basically CustomEvent.detail does no conversion of objects and will pass JS objects through unmodified.

This fix restricts CustomEvent.detail for Dart down to serialized script values, but JS allows anything (which can lead to memory leaks).

With this fix, CustomEvent.detail is essentially handled similar to MessageEvent.data.


BUG=https://code.google.com/p/dart/issues/detail?id=6220
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24884

[vsm, 2013-07-10 19:06:40]

lgtm

https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
sdk/lib/html/dartium/html_dartium.dart:6545: e.$dom_initCustomEvent(type,
canBubble, cancelable, detail);
Should the Dartium version being doing a conversion also?  Or is it already
doing it in C++?

[blois, 2013-07-10 20:10:46]

https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
sdk/lib/html/dartium/html_dartium.dart:6545: e.$dom_initCustomEvent(type,
canBubble, cancelable, detail);
On 2013/07/10 19:06:40, vsm wrote:
> Should the Dartium version being doing a conversion also?  Or is it already
> doing it in C++?

Dartium is already doing it (tests pass on Dartium), generated code for the
constructor is:

  ScriptValue detailArg =
DartUtilities::dartToScriptValue(Dart_GetNativeArgument(args, 4), exception);
  if (exception)
      goto fail;

  receiver->initCustomEvent(typeArg, canBubbleArg, cancelableArg, detailArg);

Also the getter for detail does a similar conversion.

[blois, 2013-07-10 20:12:31]

Committed patchset #1 manually as r24884 (presubmit successful).

[vsm, 2013-07-10 20:12:37]

On 2013/07/10 20:10:46, blois wrote:
>
https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
> File sdk/lib/html/dartium/html_dartium.dart (left):
> 
>
https://codereview.chromium.org/18811006/diff/1/sdk/lib/html/dartium/html_dar...
> sdk/lib/html/dartium/html_dartium.dart:6545: e.$dom_initCustomEvent(type,
> canBubble, cancelable, detail);
> On 2013/07/10 19:06:40, vsm wrote:
> > Should the Dartium version being doing a conversion also?  Or is it already
> > doing it in C++?
> 
> Dartium is already doing it (tests pass on Dartium), generated code for the
> constructor is:
> 
>   ScriptValue detailArg =
> DartUtilities::dartToScriptValue(Dart_GetNativeArgument(args, 4), exception);
>   if (exception)
>       goto fail;
> 
>   receiver->initCustomEvent(typeArg, canBubbleArg, cancelableArg, detailArg);
> 
> Also the getter for detail does a similar conversion.

Thanks, still lgtm.