Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 18811006: Fixing CustomEvent.detail leaks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/event_customevent_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index a226662e35a38f4989c545a17b92a7f5a3ac0a37..26dcd4a644867c601399fdad5d5bb06aa9246936 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -6541,7 +6541,8 @@ class CustomEvent extends Event {
factory CustomEvent(String type,
{bool canBubble: true, bool cancelable: true, Object detail}) {
- final CustomEvent e = document.$dom_createEvent("CustomEvent");
+ final CustomEvent e = document.$dom_createEvent('CustomEvent');
+
e.$dom_initCustomEvent(type, canBubble, cancelable, detail);
vsm 2013/07/10 19:06:40 Should the Dartium version being doing a conversio
blois 2013/07/10 20:10:46 Dartium is already doing it (tests pass on Dartium
return e;
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/event_customevent_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698