Issue 187693008: Script changes for ChangeXXX -> Change=XXX

Issue 187693008: Script changes for ChangeXXX -> Change=XXX (Closed)

Created:
6 years, 9 months ago by Leaf

Modified:
6 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Script changes for ChangeXXX -> Change=XXX Move CustomSetter to Custom=Setter in dart.idl BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=33359

Patch Set 2 : Addressing code review comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
	M	tools/dom/idl/dart/dart.idl	View		2 chunks	+9 lines, -9 lines	0 comments	Download
	M	tools/dom/scripts/systemnative.py	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

https://codereview.chromium.org/187693008/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/187693008/diff/1/tools/dom/scripts/systemnative.py#newcode582 tools/dom/scripts/systemnative.py:582: is_custom = 'Custom' in attr.ext_attrs and (attr.ext_attrs['Custom'] == None ...

6 years, 9 months ago (2014-03-05 23:38:35 UTC) #2

Leaf

6 years, 9 months ago (2014-03-06 00:00:12 UTC) #3

Leaf

6 years, 9 months ago (2014-03-06 00:17:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33359 (presubmit successful).

Expand Messages | Collapse Messages