Script changes for ChangeXXX -> Change=XXX

tools/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 561 matching lines @@
     return (self._interface.id, idl_name, native_suffix) not in _cpp_no_auto_scope_list
 
   def _AddGetter(self, attr, html_name, read_only):
     # Temporary hack to force dart:scalarlist clamped array for ImageData.data.
     # TODO(antonm): solve in principled way.
     if self._interface.id == 'ImageData' and html_name == 'data':
       html_name = '_data'
     type_info = self._TypeInfo(attr.type.id)
     dart_declaration = '%s get %s' % (
         self.SecureOutputType(attr.type.id, False, read_only), html_name)
-    is_custom = 'Custom' in attr.ext_attrs or 'CustomGetter' in attr.ext_attrs
+    is_custom = 'Custom' in attr.ext_attrs and (attr.ext_attrs['Custom'] == None or 

[vsm, 2014/03/05 23:38:35]

nit: 80 char limit per google style:

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length

[Leaf, 2014/03/06 00:00:13]

Done.

+                                                attr.ext_attrs['Custom'] == 'Getter')
+    # This seems to have been replaced with Custom=Getter (see above), but check to be
+    # sure we don't see the old syntax
+    assert(not ('CustomGetter' in attr.ext_attrs))
     native_suffix = 'Getter'
     auto_scope_setup = self._GenerateAutoSetupScope(attr.id, native_suffix)
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 1,
         dart_declaration, native_suffix, is_custom, auto_scope_setup)
     if is_custom:
       return
 
     if 'Reflect' in attr.ext_attrs:
       webcore_function_name = self._TypeInfo(attr.type.id).webcore_getter_name()
       if 'URL' in attr.ext_attrs:
@@ skipping 23 matching lines @@
         attr,
         [],
         attr.type.id,
         attr.type.nullable,
         raises,
         auto_scope_setup)
 
   def _AddSetter(self, attr, html_name):
     type_info = self._TypeInfo(attr.type.id)
     dart_declaration = 'void set %s(%s value)' % (html_name, self._DartType(attr.type.id))
-    is_custom = set(['Custom', 'CustomSetter', 'V8CustomSetter']) & set(attr.ext_attrs)
+    is_custom = 'Custom' in attr.ext_attrs and (attr.ext_attrs['Custom'] == None or 

[vsm, 2014/03/05 23:38:35]

ditto

[Leaf, 2014/03/06 00:00:13]

Done.

+                                                attr.ext_attrs['Custom'] == 'Setter')
+    # This seems to have been replaced with Custom=Setter (see above), but check to be
+    # sure we don't see the old syntax
+    assert(not ('CustomSetter' in attr.ext_attrs))
+    assert(not ('V8CustomSetter' in attr.ext_attrs))
     native_suffix = 'Setter'
     auto_scope_setup = self._GenerateAutoSetupScope(attr.id, native_suffix)
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 2,
         dart_declaration, native_suffix, is_custom, auto_scope_setup)
     if is_custom:
       return
 
     if 'Reflect' in attr.ext_attrs:
       webcore_function_name = self._TypeInfo(attr.type.id).webcore_setter_name()
     else:
@@ skipping 765 matching lines @@
     e.Emit("};\n");
     e.Emit('\n');
     e.Emit('} // namespace WebCore\n');
 
 def _IsOptionalStringArgumentInInitEventMethod(interface, operation, argument):
   return (
       interface.id.endswith('Event') and
       operation.id.startswith('init') and
       argument.ext_attrs.get('Default') == 'Undefined' and
       argument.type.id == 'DOMString')