Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 18600007: Relax method override restrictions. (Closed)

Created:
7 years, 5 months ago by floitsch
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, ahe
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Test and status updates. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -37 lines) Patch
M runtime/vm/object.cc View 1 2 chunks +1 line, -31 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/method_override2_test.dart View 1 3 chunks +4 lines, -4 lines 4 comments Download
A tests/language/method_override3_test.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/method_override4_test.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
A tests/language/method_override5_test.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A tests/language/method_override6_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
floitsch
This implements part of relaxing the method-overrides. With this in place, we can commit our ...
7 years, 5 months ago (2013-07-03 12:48:44 UTC) #1
regis
LGTM What else is needed before closing bug 11495?
7 years, 5 months ago (2013-07-03 16:10:45 UTC) #2
floitsch
On 2013/07/03 16:10:45, regis wrote: > LGTM > > What else is needed before closing ...
7 years, 5 months ago (2013-07-03 16:12:02 UTC) #3
floitsch
Committed patchset #1 manually as r24731 (presubmit successful).
7 years, 5 months ago (2013-07-03 16:20:14 UTC) #4
floitsch
Updated tests and status files. Added Peter for the method_override2_test change.
7 years, 5 months ago (2013-07-03 18:01:25 UTC) #5
floitsch
Committed patchset #2 manually as r24736 (presubmit successful).
7 years, 5 months ago (2013-07-03 18:02:23 UTC) #6
ahe
https://codereview.chromium.org/18600007/diff/6001/tests/language/method_override2_test.dart File tests/language/method_override2_test.dart (right): https://codereview.chromium.org/18600007/diff/6001/tests/language/method_override2_test.dart#newcode8 tests/language/method_override2_test.dart:8: m(x, {a, b}); I don't think this change is ...
7 years, 5 months ago (2013-07-11 10:26:00 UTC) #7
floitsch
7 years, 5 months ago (2013-07-11 11:18:47 UTC) #8
Message was sent while issue was closed.
Uploaded a follow up CL.
https://codereview.chromium.org/18531006

https://codereview.chromium.org/18600007/diff/6001/tests/language/method_over...
File tests/language/method_override2_test.dart (right):

https://codereview.chromium.org/18600007/diff/6001/tests/language/method_over...
tests/language/method_override2_test.dart:8: m(x, {a, b});
On 2013/07/11 10:26:01, ahe wrote:
> I don't think this change is correct.
> 
> If the specification says that this is just a warning, the test tags should be
> updated.

Yes. I didn't have access to the latest spec and didn't know that the spec also
changed for required parameters.

Powered by Google App Engine
This is Rietveld 408576698