Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 18531006: Update test and status file. (Closed)

Created:
7 years, 5 months ago by floitsch
Modified:
7 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More updates #

Total comments: 2

Patch Set 3 : Revert test-change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -24 lines) Patch
M tests/language/language.status View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +7 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +7 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/method_override2_test.dart View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language/method_override3_test.dart View 1 chunk +25 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
7 years, 5 months ago (2013-07-11 11:18:20 UTC) #1
ahe
Thank you, Florian. I'm still a little confused about the original modifications to the test, ...
7 years, 5 months ago (2013-07-11 11:29:23 UTC) #2
floitsch
Reverted test to before the relaxing. Goal wast to keep coverage of the tests, but ...
7 years, 5 months ago (2013-07-11 11:34:50 UTC) #3
ahe
LGTM!
7 years, 5 months ago (2013-07-11 11:35:50 UTC) #4
floitsch
7 years, 5 months ago (2013-07-11 11:36:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r24910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698