Add stackTrace to Error object.

Add stackTrace to Error object.

BUG=
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24726

[floitsch, 2013-07-02 19:08:39]

Please remind me to add issue numbers for the two projects (VM/dart2js and
co19).

[Lasse Reichstein Nielsen, 2013-07-03 13:06:13]

LGTM, under duress.

https://codereview.chromium.org/18529003/diff/2001/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/18529003/diff/2001/runtime/lib/errors_patch.d...
runtime/lib/errors_patch.dart:10: // TODO(XYZ): implement stackTrace on Error.
XYZ -> number.

https://codereview.chromium.org/18529003/diff/2001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/18529003/diff/2001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:959: // TODO(regis, 5802): Exception to throw is not
specified by spec.
I think there was another issue too. Mentioned in previous CL.

https://codereview.chromium.org/18529003/diff/2001/sdk/lib/_internal/lib/core...
File sdk/lib/_internal/lib/core_patch.dart (right):

https://codereview.chromium.org/18529003/diff/2001/sdk/lib/_internal/lib/core...
sdk/lib/_internal/lib/core_patch.dart:118: // TODO(XYZ): implement stackTrace in
error object.
XYZ->number.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer.s...
File tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer.s...
tests/co19/co19-analyzer.status:194:
LibTest/core/FallThroughError/toString_A01_t01: Fail # FallThroughError is no
longer const. Issue TODO
Do too!

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer2....
File tests/co19/co19-analyzer2.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer2....
tests/co19/co19-analyzer2.status:122:
LibTest/core/FallThroughError/toString_A01_t01: Fail # FallThroughError is no
longer const. Issue TODO
Do the todo.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-compiler.s...
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-compiler.s...
tests/co19/co19-compiler.status:281:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
And do this too.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2dart....
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2dart....
tests/co19/co19-dart2dart.status:597: 
Again.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:548:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
And again.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-runtime.st...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-runtime.st...
tests/co19/co19-runtime.status:431:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
And again.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:44: error_stack_trace_test: Fail  # Bug TODO
This one too.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:59: error_stack_trace2_test: Fail  # Bug TODO
And this.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
File tests/corelib/error_stack_trace2_test.dart (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
tests/corelib/error_stack_trace2_test.dart:16: cyclicStatic + 1;
So this should catch the stack in "some code called by this read"?

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
File tests/corelib/error_stack_trace_test.dart (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
tests/corelib/error_stack_trace_test.dart:7: argument() {
void return type, please. Makes it more readable.

[floitsch, 2013-07-03 14:50:19]

https://codereview.chromium.org/18529003/diff/2001/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/18529003/diff/2001/runtime/lib/errors_patch.d...
runtime/lib/errors_patch.dart:10: // TODO(XYZ): implement stackTrace on Error.
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> XYZ -> number.

Done.

https://codereview.chromium.org/18529003/diff/2001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/18529003/diff/2001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:959: // TODO(regis, 5802): Exception to throw is not
specified by spec.
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> I think there was another issue too. Mentioned in previous CL.

I closed the other.

https://codereview.chromium.org/18529003/diff/2001/sdk/lib/_internal/lib/core...
File sdk/lib/_internal/lib/core_patch.dart (right):

https://codereview.chromium.org/18529003/diff/2001/sdk/lib/_internal/lib/core...
sdk/lib/_internal/lib/core_patch.dart:118: // TODO(XYZ): implement stackTrace in
error object.
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> XYZ->number.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer.s...
File tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer.s...
tests/co19/co19-analyzer.status:194:
LibTest/core/FallThroughError/toString_A01_t01: Fail # FallThroughError is no
longer const. Issue TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> Do too!

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer2....
File tests/co19/co19-analyzer2.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-analyzer2....
tests/co19/co19-analyzer2.status:122:
LibTest/core/FallThroughError/toString_A01_t01: Fail # FallThroughError is no
longer const. Issue TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> Do the todo.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-compiler.s...
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-compiler.s...
tests/co19/co19-compiler.status:281:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> And do this too.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2dart....
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2dart....
tests/co19/co19-dart2dart.status:597: 
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> Again.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:548:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> And again.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-runtime.st...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/co19/co19-runtime.st...
tests/co19/co19-runtime.status:431:
LibTest/core/FallThroughError/FallThroughError_A01_t01: Fail # FallThroughError
is no longer const. Issue TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> And again.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:44: error_stack_trace_test: Fail  # Bug TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> This one too.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:59: error_stack_trace2_test: Fail  # Bug TODO
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> And this.

Done.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
File tests/corelib/error_stack_trace2_test.dart (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
tests/corelib/error_stack_trace2_test.dart:16: cyclicStatic + 1;
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> So this should catch the stack in "some code called by this read"?

Somewhere in here. I don't think it is necessary to exactly know where, as long
as it contains the stack up to the first access of the cyclic variable.

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
File tests/corelib/error_stack_trace_test.dart (right):

https://codereview.chromium.org/18529003/diff/2001/tests/corelib/error_stack_...
tests/corelib/error_stack_trace_test.dart:7: argument() {
On 2013/07/03 13:06:13, Lasse Reichstein Nielsen wrote:
> void return type, please. Makes it more readable.

Done.

[floitsch, 2013-07-03 14:51:43]

Committed patchset #3 manually as r24726 (presubmit successful).