Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: runtime/lib/errors_patch.dart

Issue 18529003: Add stackTrace to Error object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments and add bug numbers to status files. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/error.dart ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/errors_patch.dart
diff --git a/runtime/lib/errors_patch.dart b/runtime/lib/errors_patch.dart
index f52ff8f14a582cadd5c8e6e5d6611e477b662b9f..f14a50441bbd4e42e92db26a9034712aaf8a3cb5 100644
--- a/runtime/lib/errors_patch.dart
+++ b/runtime/lib/errors_patch.dart
@@ -6,6 +6,9 @@ patch class Error {
/* patch */ static String _objectToString(Object object) {
return Object._toString(object);
}
+
+ // TODO(11680): implement stackTrace on Error.
+ /* patch */ StackTrace get stackTrace => null;
}
patch class NoSuchMethodError {
@@ -38,11 +41,11 @@ patch class NoSuchMethodError {
namedArguments[argumentNames[i]] = arg_value;
}
throw new NoSuchMethodError._withType(receiver,
- memberName,
- invocation_type,
- positionalArguments,
- namedArguments,
- existingArgumentNames);
+ memberName,
+ invocation_type,
+ positionalArguments,
+ namedArguments,
+ existingArgumentNames);
}
// Remember the type from the invocation mirror or static compilation
@@ -50,20 +53,20 @@ patch class NoSuchMethodError {
// that no information is available.
final int _invocation_type;
- const NoSuchMethodError(Object this._receiver,
- String this._memberName,
- List this._arguments,
- Map<String,dynamic> this._namedArguments,
- [List existingArgumentNames = null])
+ NoSuchMethodError(Object this._receiver,
+ String this._memberName,
+ List this._arguments,
+ Map<String,dynamic> this._namedArguments,
+ [List existingArgumentNames = null])
: this._existingArgumentNames = existingArgumentNames,
this._invocation_type = -1;
- const NoSuchMethodError._withType(Object this._receiver,
- String this._memberName,
- this._invocation_type,
- List this._arguments,
- Map<String,dynamic> this._namedArguments,
- [List existingArgumentNames = null])
+ NoSuchMethodError._withType(Object this._receiver,
+ String this._memberName,
+ this._invocation_type,
+ List this._arguments,
+ Map<String,dynamic> this._namedArguments,
+ [List existingArgumentNames = null])
: this._existingArgumentNames = existingArgumentNames;
@@ -170,9 +173,9 @@ patch class NoSuchMethodError {
}
}
-class _FiftyThreeBitOverflowError implements Error {
+class _FiftyThreeBitOverflowError extends Error {
final Object _value;
- const _FiftyThreeBitOverflowError(this._value);
+ _FiftyThreeBitOverflowError(this._value);
String toString() => "53-bit Overflow: $_value";
}
« no previous file with comments | « runtime/lib/error.dart ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698