Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185053005: Revert "Constrain type annotations with deferred types." (Closed)

Created:
6 years, 9 months ago by sigurdm
Modified:
6 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Constrain type annotations with deferred types." This reverts commit 33273 and 33276. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=33277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -267 lines) Patch
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 7 chunks +9 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/builder.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 6 chunks +22 lines, -55 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/deferred_emit_type_checks_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/language/deferred_constraints_lib.dart View 1 chunk +1 line, -5 lines 0 comments Download
M tests/language/deferred_constraints_lib2.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/deferred_constraints_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
M tests/language/deferred_duplicate_prefix1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/deferred_duplicate_prefix2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/deferred_duplicate_prefix3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/deferred_no_prefix_test.dart View 1 chunk +1 line, -6 lines 0 comments Download
D tests/language/deferred_prefix_constraints_lib.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/deferred_prefix_constraints_lib2.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -25 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -13 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurdm
6 years, 9 months ago (2014-03-04 15:23:13 UTC) #1
karlklose
LGTM.
6 years, 9 months ago (2014-03-04 15:24:52 UTC) #2
sigurdm
6 years, 9 months ago (2014-03-04 15:27:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r33277 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698