Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

Issue 185053005: Revert "Constrain type annotations with deferred types." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 class CheckedModeHelper { 7 class CheckedModeHelper {
8 final String name; 8 final String name;
9 9
10 const CheckedModeHelper(String this.name); 10 const CheckedModeHelper(String this.name);
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 const PropertyCheckedModeHelper('propertyTypeCheck')]; 66 const PropertyCheckedModeHelper('propertyTypeCheck')];
67 } 67 }
68 68
69 class MalformedCheckedModeHelper extends CheckedModeHelper { 69 class MalformedCheckedModeHelper extends CheckedModeHelper {
70 const MalformedCheckedModeHelper(String name) : super(name); 70 const MalformedCheckedModeHelper(String name) : super(name);
71 71
72 void generateAdditionalArguments(SsaCodeGenerator codegen, 72 void generateAdditionalArguments(SsaCodeGenerator codegen,
73 HTypeConversion node, 73 HTypeConversion node,
74 List<jsAst.Expression> arguments) { 74 List<jsAst.Expression> arguments) {
75 ErroneousElement element = node.typeExpression.element; 75 ErroneousElement element = node.typeExpression.element;
76 arguments.add(js.escapedString(element.message)); 76 arguments.add(js.string(element.message));
77 } 77 }
78 } 78 }
79 79
80 class PropertyCheckedModeHelper extends CheckedModeHelper { 80 class PropertyCheckedModeHelper extends CheckedModeHelper {
81 const PropertyCheckedModeHelper(String name) : super(name); 81 const PropertyCheckedModeHelper(String name) : super(name);
82 82
83 void generateAdditionalArguments(SsaCodeGenerator codegen, 83 void generateAdditionalArguments(SsaCodeGenerator codegen,
84 HTypeConversion node, 84 HTypeConversion node,
85 List<jsAst.Expression> arguments) { 85 List<jsAst.Expression> arguments) {
86 DartType type = node.typeExpression; 86 DartType type = node.typeExpression;
(...skipping 23 matching lines...) Expand all
110 DartType type = node.typeExpression; 110 DartType type = node.typeExpression;
111 Element element = type.element; 111 Element element = type.element;
112 String isField = codegen.backend.namer.operatorIs(element); 112 String isField = codegen.backend.namer.operatorIs(element);
113 arguments.add(js.string(isField)); 113 arguments.add(js.string(isField));
114 codegen.use(node.typeRepresentation); 114 codegen.use(node.typeRepresentation);
115 arguments.add(codegen.pop()); 115 arguments.add(codegen.pop());
116 String asField = codegen.backend.namer.substitutionName(element); 116 String asField = codegen.backend.namer.substitutionName(element);
117 arguments.add(js.string(asField)); 117 arguments.add(js.string(asField));
118 } 118 }
119 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698