Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184893003: New analyzer snapshot. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer snapshot. No 'isInstanceOf' changes yet. Just current state with changes required to adopt to the API changes in Java. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33176

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+5072 lines, -2137 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/context/AnalysisContext.java View 1 chunk +1 line, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java View 2 chunks +2 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/Source.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/source/TestSource.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/builder/MockContext.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 4 chunks +45 lines, -43 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/test_support_include.dart View 2 chunks +4 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 6 chunks +58 lines, -16 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 5 chunks +9 lines, -8 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/SemanticProcessor.java View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/error.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 5 chunks +23 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 52 chunks +494 lines, -75 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 150 chunks +1208 lines, -475 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 16 chunks +41 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 7 chunks +38 lines, -166 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 11 chunks +56 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 4 chunks +45 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 9 chunks +48 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 85 chunks +993 lines, -393 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 4 chunks +35 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 6 chunks +34 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 15 chunks +38 lines, -76 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 9 chunks +39 lines, -53 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/string_source.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 190 chunks +576 lines, -477 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 90 chunks +1187 lines, -171 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/services/test_utils.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/code_transformers/lib/src/resolver_impl.dart View 10 chunks +20 lines, -14 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +9 lines, -8 lines 3 comments Download
M tests/language/language_analyzer2.status View 5 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scheglov
6 years, 9 months ago (2014-02-28 21:48:17 UTC) #1
Brian Wilkerson
Do we need to update the analyzer's pubspec.yaml? Other than that, LGTM. https://codereview.chromium.org/184893003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/context/AnalysisContext.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/context/AnalysisContext.java ...
6 years, 9 months ago (2014-02-28 22:30:37 UTC) #2
scheglov
Committed patchset #1 manually as r33176 (presubmit successful).
6 years, 9 months ago (2014-02-28 22:52:37 UTC) #3
blois
https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspec.yaml#newcode10 pkg/code_transformers/pubspec.yaml:10: path: /Users/scheglov/Source/Dart/dart/pkg/analyzer Incorrect path.
6 years, 9 months ago (2014-03-01 00:35:21 UTC) #4
scheglov
https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspec.yaml#newcode10 pkg/code_transformers/pubspec.yaml:10: path: /Users/scheglov/Source/Dart/dart/pkg/analyzer On 2014/03/01 00:35:22, blois wrote: > Incorrect ...
6 years, 9 months ago (2014-03-01 05:22:42 UTC) #5
blois
6 years, 9 months ago (2014-03-01 16:09:09 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspe...
File pkg/code_transformers/pubspec.yaml (right):

https://codereview.chromium.org/184893003/diff/1/pkg/code_transformers/pubspe...
pkg/code_transformers/pubspec.yaml:10: path:
/Users/scheglov/Source/Dart/dart/pkg/analyzer
On 2014/03/01 05:22:43, scheglov wrote:
> On 2014/03/01 00:35:22, blois wrote:
> > Incorrect path.
> 
> Yes, forgot to rollback changes in this file after local testing.
> Rolled it back before commit though.

It was rolled back to 0.12.0, but analyzer is now 0.13

Powered by Google App Engine
This is Rietveld 408576698