Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: pkg/analyzer/lib/src/generated/constant.dart

Issue 184893003: New analyzer snapshot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/constant.dart
diff --git a/pkg/analyzer/lib/src/generated/constant.dart b/pkg/analyzer/lib/src/generated/constant.dart
index 5b2378449dbc4be0bc6513d19996c4c6e7bcb6b4..752f0e482fbeaa944b98edb0f7d50bc7b896a19e 100644
--- a/pkg/analyzer/lib/src/generated/constant.dart
+++ b/pkg/analyzer/lib/src/generated/constant.dart
@@ -517,11 +517,12 @@ class ConstantVisitor extends UnifyingASTVisitor<EvaluationResultImpl> {
return leftResult.divide(_typeProvider, node, rightResult);
} else if (operatorType == TokenType.TILDE_SLASH) {
return leftResult.integerDivide(_typeProvider, node, rightResult);
+ } else {
+ // TODO(brianwilkerson) Figure out which error to report.
+ return error(node, null);
}
break;
}
- // TODO(brianwilkerson) Figure out which error to report.
- return error(node, null);
}
EvaluationResultImpl visitBooleanLiteral(BooleanLiteral node) => valid2(_typeProvider.boolType, BoolState.from(node.value));
@@ -724,11 +725,12 @@ class ConstantVisitor extends UnifyingASTVisitor<EvaluationResultImpl> {
return operand.bitNot(_typeProvider, node);
} else if (node.operator.type == TokenType.MINUS) {
return operand.negated(_typeProvider, node);
+ } else {
+ // TODO(brianwilkerson) Figure out which error to report.
+ return error(node, null);
}
break;
}
- // TODO(brianwilkerson) Figure out which error to report.
- return error(node, null);
}
EvaluationResultImpl visitPropertyAccess(PropertyAccess node) => getConstantValue(node, node.propertyName.staticElement);

Powered by Google App Engine
This is Rietveld 408576698