Issue 18446004: Revert "Add fillRange to typed ungrowable lists."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18446004: Revert "Add fillRange to typed ungrowable lists." (Closed)

Created:
7 years, 5 months ago by floitsch

Modified:
7 years, 5 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, zarah

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Add fillRange to typed ungrowable lists." Revert "fix type in test." This reverts commit r24689. This reverts commit r24695. Test is in the wrong place, and Stephen's (sra) CL makes the other change unnecessary. https://codereview.chromium.org/18391002/ Committed: https://code.google.com/p/dart/source/detail?r=24703

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -136 lines)			Patch
	M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
	D	tests/corelib/list_ungrowable_fillRange_test.dart	View		1 chunk	+0 lines, -127 lines	0 comments	Download

Total messages: 2 (0 generated)

floitsch

TBR. (breaks IE on the buildbot, since IE doesn't have typed data).

7 years, 5 months ago (2013-07-02 19:05:48 UTC) #1

floitsch

7 years, 5 months ago (2013-07-02 19:06:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r24703 (presubmit successful).