Issue 183973035: More performance fixes.

Issue 183973035: More performance fixes. (Closed)

Created:
6 years, 9 months ago by srdjan

Modified:
6 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More performance fixes. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33389

Patch Set 8 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
M	runtime/vm/object.cc	View	1 2 3 4 5 6 7	2 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment about the NoGCScope over a loop. https://codereview.chromium.org/183973035/diff/60002/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/183973035/diff/60002/runtime/vm/object.cc#newcode11120 ...

6 years, 9 months ago (2014-03-06 18:46:59 UTC) #2

srdjan

https://codereview.chromium.org/183973035/diff/60002/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/183973035/diff/60002/runtime/vm/object.cc#newcode11120 runtime/vm/object.cc:11120: RawFunction* first_target = GetTargetAt(0); On 2014/03/06 18:47:00, siva wrote: ...

6 years, 9 months ago (2014-03-06 18:50:53 UTC) #3

srdjan

6 years, 9 months ago (2014-03-06 19:00:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #8 manually as r33389 (presubmit successful).

Expand Messages | Collapse Messages