More performance fixes.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 10946 matching lines @@
 
 intptr_t ICData::GetReceiverClassIdAt(intptr_t index) const {
   ASSERT(index < NumberOfChecks());
   const Array& data = Array::Handle(ic_data());
   const intptr_t data_pos = index * TestEntryLength();
   return Smi::Value(Smi::RawCast(data.At(data_pos)));
 }
 
 
 RawFunction* ICData::GetTargetAt(intptr_t index) const {
-  const Array& data = Array::Handle(ic_data());
   const intptr_t data_pos = index * TestEntryLength() + num_args_tested();
-  ASSERT(Object::Handle(data.At(data_pos)).IsFunction());
-  return reinterpret_cast<RawFunction*>(data.At(data_pos));
+  ASSERT(Object::Handle(Array::Handle(ic_data()).At(data_pos)).IsFunction());
+
+  NoGCScope no_gc;
+  RawArray* raw_data = ic_data();
+  return reinterpret_cast<RawFunction*>(raw_data->ptr()->data()[data_pos]);
 }
 
 
 void ICData::IncrementCountAt(intptr_t index, intptr_t value) const {
   ASSERT(0 <= value);
   ASSERT(value <= Smi::kMaxValue);
   SetCountAt(index, Utils::Minimum(GetCountAt(index) + value, Smi::kMaxValue));
 }
 
 
@@ skipping 124 matching lines @@
       return true;
     }
   }
   return false;
 }
 
 
 // Returns true if all targets are the same.
 // TODO(srdjan): if targets are native use their C_function to compare.
 bool ICData::HasOneTarget() const {
-  ASSERT(NumberOfChecks() > 0);
-  const Function& first_target = Function::Handle(GetTargetAt(0));
   const intptr_t len = NumberOfChecks();
+  ASSERT(len > 0);
+  NoGCScope no_gc;
+  RawFunction* first_target = GetTargetAt(0);

[siva, 2014/03/06 18:47:00]

I am a little bit concerned about putting a NoGCScope around a loop here, If
this is a super hot spot maybe we can consider this.

[srdjan, 2014/03/06 18:50:53]

I agree with your concern, reverting code of this function.

   for (intptr_t i = 1; i < len; i++) {
-    if (GetTargetAt(i) != first_target.raw()) {
+    if (GetTargetAt(i) != first_target) {
       return false;
     }
   }
   return true;
 }
 
 
 RawICData* ICData::New(const Function& function,
                        const String& target_name,
                        const Array& arguments_descriptor,
@@ skipping 168 matching lines @@
   return result.raw();
 }
 
 
 void SubtypeTestCache::set_cache(const Array& value) const {
   StorePointer(&raw_ptr()->cache_, value.raw());
 }
 
 
 intptr_t SubtypeTestCache::NumberOfChecks() const {
+  NoGCScope no_gc;
   // Do not count the sentinel;
-  return (Array::Handle(cache()).Length() / kTestEntryLength) - 1;
+  return (Smi::Value(cache()->ptr()->length_) / kTestEntryLength) - 1;
 }
 
 
 void SubtypeTestCache::AddCheck(
     intptr_t instance_class_id,
     const TypeArguments& instance_type_arguments,
     const TypeArguments& instantiator_type_arguments,
     const Bool& test_result) const {
   intptr_t old_num = NumberOfChecks();
   Array& data = Array::Handle(cache());
@@ skipping 6187 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart