Issue 183743032: Reapply "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183743032: Reapply "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell."" (Closed)

Created:
6 years, 9 months ago by Bill Hesse

Modified:
6 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell."" This reapplies r33369. A git dependency was missing, meaning the sdk was not rebuilt, even though we add two .js files to it. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=33378

Patch Set 1 #

Patch Set 2 : Correctly break a string that is a long line. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
M	dart.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/lib/preambles/d8.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/_internal/lib/preambles/jsshell.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View		7 chunks	+24 lines, -2 lines	0 comments	Download
M	tools/testing/dart/runtime_configuration.dart	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

6 years, 9 months ago (2014-03-06 15:08:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33378 (presubmit successful).

Expand Messages | Collapse Messages