Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 183743032: Reapply "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Correctly break a string that is a long line. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index fd30dd9931b165908781672498d332ab5ec5a407..3fa2ef345a51f2606db18b7667bbbce4cba866e9 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -76,6 +76,8 @@ class RuntimeConfiguration {
// TODO(ahe): Make this method abstract.
throw "Unimplemented runtime '$runtimeType'";
}
+
+ List<String> dart2jsPreambles(Uri preambleDir) => [];
}
/// The 'none' runtime configuration.
@@ -124,6 +126,10 @@ class D8RuntimeConfiguration extends CommandLineJavaScriptRuntime {
commandBuilder.getJSCommandlineCommand(
moniker, suite.d8FileName, arguments, environmentOverrides)];
}
+
+ List<String> dart2jsPreambles(Uri preambleDir) {
+ return [preambleDir.resolve('d8.js').toFilePath()];
+ }
}
/// Firefox/SpiderMonkey-based development shell (jsshell).
@@ -142,6 +148,10 @@ class JsshellRuntimeConfiguration extends CommandLineJavaScriptRuntime {
commandBuilder.getJSCommandlineCommand(
moniker, suite.jsShellFileName, arguments, environmentOverrides)];
}
+
+ List<String> dart2jsPreambles(Uri preambleDir) {
+ return ['-f', preambleDir.resolve('jsshell.js').toFilePath(), '-f'];
+ }
}
/// Common runtime configuration for runtimes based on the Dart VM.
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698