Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1834783004: Merge in changes from SDK branch (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/fixnum@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge in changes from SDK branch Includes performance fixes and error tests. R=kevmoo@google.com Committed: https://github.com/dart-lang/fixnum/commit/b212014a1344bff235e39ed2ec0fb60a8ae7e3cb

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -167 lines) Patch
M README.md View 1 1 chunk +0 lines, -8 lines 0 comments Download
M lib/src/int32.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M lib/src/int64.dart View 28 chunks +62 lines, -123 lines 0 comments Download
M lib/src/intx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/int32_test.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M test/int64_test.dart View 19 chunks +40 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
Once this gets landed I'll try depending on it in the SDK.
4 years, 9 months ago (2016-03-25 23:03:25 UTC) #2
kevmoo
lgtm https://codereview.chromium.org/1834783004/diff/20001/README.md File README.md (right): https://codereview.chromium.org/1834783004/diff/20001/README.md#newcode15 README.md:15: ## Installation Just kill this whole section – ...
4 years, 9 months ago (2016-03-26 05:39:48 UTC) #4
kevmoo
On 2016/03/26 05:39:48, kevmoo wrote: > lgtm > > https://codereview.chromium.org/1834783004/diff/20001/README.md > File README.md (right): > ...
4 years, 8 months ago (2016-04-01 21:15:46 UTC) #5
sra1
4 years, 8 months ago (2016-04-21 17:12:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
b212014a1344bff235e39ed2ec0fb60a8ae7e3cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698