Issue 18343005: Implement dynamicType and voidType as TypeMirrors not ClassMirrors. Issue 11743.

Issue 18343005: Implement dynamicType and voidType as TypeMirrors not ClassMirrors. Issue 11743. (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement dynamicType and voidType as TypeMirrors not ClassMirrors. Issue 11743. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25010

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -12 lines)			Patch
	M	runtime/lib/mirrors_impl.dart	View	1 2 3	3 chunks	+27 lines, -12 lines	0 comments	Download
	M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Unburdens one special case from the class mirrors implementation. Still leaves the function type case ...

7 years, 5 months ago (2013-07-12 17:31:41 UTC) #1

siva

lgtm https://codereview.chromium.org/18343005/diff/7001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/18343005/diff/7001/runtime/lib/mirrors_impl.dart#newcode88 runtime/lib/mirrors_impl.dart:88: // implementation. The TODO(11743) can go right? https://codereview.chromium.org/18343005/diff/7001/runtime/lib/mirrors_impl.dart#newcode1026 ...

7 years, 5 months ago (2013-07-15 05:47:10 UTC) #3

rmacnak

On 2013/07/15 05:47:10, siva wrote: > lgtm > > https://codereview.chromium.org/18343005/diff/7001/runtime/lib/mirrors_impl.dart > File runtime/lib/mirrors_impl.dart (right): > ...

7 years, 5 months ago (2013-07-15 16:25:45 UTC) #4

rmacnak

7 years, 5 months ago (2013-07-15 16:32:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r25010 (presubmit successful).

Expand Messages | Collapse Messages