Implement dynamicType and voidType as TypeMirrors not ClassMirrors. Issue 11743.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
   return (value == null || value is num || value is String || value is bool);
 }
@@ skipping 67 matching lines @@
   // Change parameter back to "this.libraries" when native code is changed.
   _LocalMirrorSystemImpl(Map<String, LibraryMirror> libraries, this.isolate)
       : this.libraries = _createLibrariesMap(libraries),
         _functionTypes = new Map<String, FunctionTypeMirror>();
 
   final Map<Uri, LibraryMirror> libraries;
   final IsolateMirror isolate;
 
   // TODO(11743): dynamicType and voidType should not respond to the 
   // ClassMirror protocol, so they should not inherit from the ClassMirror
   // implementation.

[siva, 2013/07/15 05:47:11]

The TODO(11743) can go right?

 
   TypeMirror _dynamicType = null;
 
   TypeMirror get dynamicType {
     if (_dynamicType == null) {
-      _dynamicType =
-          new _LocalClassMirrorImpl(
-              null, null, 'dynamic', false, null, null, [], null,
-              const {}, const {}, const {});
+      _dynamicType = new _SpecialTypeMirrorImpl(_s('dynamic'));
     }
     return _dynamicType;
   }
 
   TypeMirror _voidType = null;
 
   TypeMirror get voidType {
     if (_voidType == null) {
-      _voidType =
-          new _LocalClassMirrorImpl(
-              null, null, 'void', false, null, null, [], null,
-              const {}, const {}, const {});
+      _voidType = new _SpecialTypeMirrorImpl(_s('void'));
     }
     return _voidType;
   }
 
   final Map<String, FunctionTypeMirror> _functionTypes;
   FunctionTypeMirror _lookupFunctionTypeMirror(
       TypeMirror returnType,
       List<ParameterMirror> parameters) {
     var sigString = _makeSignatureString(returnType, parameters);
     var mirror = _functionTypes[sigString];
@@ skipping 896 matching lines @@
     throw new UnimplementedError(
         'ParameterMirror.defaultValue is not implemented');
   }
 
   bool get hasDefaultValue {
     throw new UnimplementedError(
         'ParameterMirror.hasDefaultValue is not implemented');
   }
 }
 
+class _SpecialTypeMirrorImpl extends _LocalMirrorImpl
+    implements TypeMirror, DeclarationMirror {
+  _SpecialTypeMirrorImpl(this.simpleName);
+
+  final bool isPrivate = false;
+  final bool isTopLevel = true;
+  final List<InstanceMirror> metadata = new List(0);  // Fixed length 0, therefore immutable.

[siva, 2013/07/15 05:47:11]

Does the comment line fit in 80 chars?

+  final DeclarationMirror owner = null;
+  final Symbol simpleName;
+
+  SourceLocation get location {
+    throw new UnimplementedError(
+        'TypeMirror.location is not implemented');
+  }
+
+  Symbol get qualifiedName {
+    return simpleName;
+  }
+
+  String toString() => "TypeMirror on '${_n(simpleName)}'";
+}
+
 class _Mirrors {
   // Does a port refer to our local isolate?
   static bool isLocalPort(SendPort port) native 'Mirrors_isLocalPort';
 
   static MirrorSystem _currentMirrorSystem = null;
 
   // Creates a new local MirrorSystem.
   static MirrorSystem makeLocalMirrorSystem()
       native 'Mirrors_makeLocalMirrorSystem';
 
@@ skipping 30 matching lines @@
   }
 
   // Creates a new local ClassMirror.
   static ClassMirror makeLocalClassMirror(Type key)
       native "Mirrors_makeLocalClassMirror";
 
   static ClassMirror reflectClass(Type key) {
     return makeLocalClassMirror(key);
   }
 }