Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 18341022: Report REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24833

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 5 months ago (2013-07-08 23:54:52 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/18341022/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java (right): https://codereview.chromium.org/18341022/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java#newcode1098 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:1098: // TODO(scheglov) What's left to do?
7 years, 5 months ago (2013-07-09 00:22:50 UTC) #2
scheglov
7 years, 5 months ago (2013-07-09 02:21:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698