editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java - Issue 18341022: Report REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

Issue 18341022: Report REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java » ('j') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

index 1252b1b69b9c7ddfd3b36e809b3b25d4316ea4f9..43cf7b6fed25caa4ee5a0706e1396068be63b562 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

@@ -2276,6 +2276,9 @@ public class Parser {

separator = getAndAdvance();

redirectedConstructor = parseConstructorName();

body = new EmptyFunctionBody(expect(TokenType.SEMICOLON));

+ if (factoryKeyword == null) {

+ reportError(ParserErrorCode.REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR, redirectedConstructor);

+ }

} else {

body = parseFunctionBody(true, ParserErrorCode.MISSING_FUNCTION_BODY, false);

if (constKeyword != null && factoryKeyword != null) {