Make the Firefox trace RegExp not go exponential on V8.

Make the Firefox trace RegExp not go exponential on V8.

BUG=11645
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24829

[Bob Nystrom, 2013-07-08 22:02:27]

One suggestion then LGTM.

https://codereview.chromium.org/18339005/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/18339005/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:22: final _firefoxTrace = new
RegExp(r"^([.0-9A-Za-z_$/<]|\(.*\))*@");
I think this would handle this poorly:

.VW.call$0(")")@http://pub.dartlang.org/stuff.dart.js:560

Add a TODO for that?

[nweiz, 2013-07-08 22:24:49]

https://codereview.chromium.org/18339005/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/18339005/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:22: final _firefoxTrace = new
RegExp(r"^([.0-9A-Za-z_$/<]|\(.*\))*@");
On 2013/07/08 22:02:27, Bob Nystrom wrote:
> I think this would handle this poorly:
> 
> .VW.call$0(")")@http://pub.dartlang.org/stuff.dart.js:560
> 
> Add a TODO for that?

The ".*" in "\(.*\)" is greedy; it'll match until the last ")". There's a test
case for that.

[nweiz, 2013-07-08 22:25:13]

Committed patchset #1 manually as r24829 (presubmit successful).