Issue 183333003: Adding 'preview' to typedef

Issue 183333003: Adding 'preview' to typedef (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding 'preview' to typedef Removed call to non-existent _moveDirectoryAndReplace updated min scheduled_test version R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=33338

Patch Set 2 : added back _moveDirectoryAndServe #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -16 lines)			Patch
M	pkg/docgen/lib/docgen.dart	View	1	3 chunks	+56 lines, -11 lines	2 comments	Download
M	pkg/docgen/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/docgen/test/generate_json_test.dart	View		2 chunks	+36 lines, -0 lines	0 comments	Download
M	pkg/docgen/test/multi_library_code/lib/temp3.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kevmoo

This is mostly adding 'preview' to typedef so that they look like other classes listed. ...

6 years, 9 months ago (2014-03-05 00:40:21 UTC) #1

kevmoo

See sister CL here https://codereview.chromium.org/184993010/

6 years, 9 months ago (2014-03-05 00:43:05 UTC) #2

Emily Fortuna

https://codereview.chromium.org/183333003/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/183333003/diff/1/pkg/docgen/lib/docgen.dart#newcode723 pkg/docgen/lib/docgen.dart:723: // _moveDirectoryAndServe(); I thought you were going to add ...

6 years, 9 months ago (2014-03-05 01:35:29 UTC) #3

kevmoo

PTAL https://codereview.chromium.org/183333003/diff/20001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/183333003/diff/20001/pkg/docgen/lib/docgen.dart#newcode755 pkg/docgen/lib/docgen.dart:755: static void _moveDirectoryAndServe() { I just grabbed it ...

6 years, 9 months ago (2014-03-05 03:57:18 UTC) #4

Emily Fortuna

lgtm https://codereview.chromium.org/183333003/diff/20001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/183333003/diff/20001/pkg/docgen/lib/docgen.dart#newcode755 pkg/docgen/lib/docgen.dart:755: static void _moveDirectoryAndServe() { On 2014/03/05 03:57:18, kevmoo ...

6 years, 9 months ago (2014-03-05 18:30:36 UTC) #5

kevmoo

6 years, 9 months ago (2014-03-05 18:48:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r33338 (presubmit successful).

Expand Messages | Collapse Messages