Issue 18331006: Adds support for integer division for ARM chips without the sdiv instruction.

Issue 18331006: Adds support for integer division for ARM chips without the sdiv instruction. (Closed)

Created:
7 years, 5 months ago by zra

Modified:
7 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds support for integer division for ARM chips without the sdiv instruction. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24635

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -17 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		6 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Tests passed with integer_division_supported_ hardcoded to false, but I've left it set to true for ...

7 years, 5 months ago (2013-07-01 16:24:51 UTC) #1

regis

LGTM with one suggestion. https://codereview.chromium.org/18331006/diff/10001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/18331006/diff/10001/runtime/vm/assembler_arm.cc#newcode1954 runtime/vm/assembler_arm.cc:1954: vmovsr(STMP, left); STMP -> static_cast<SRegister>(2 ...

7 years, 5 months ago (2013-07-01 16:54:09 UTC) #2

zra

Thanks! https://codereview.chromium.org/18331006/diff/10001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/18331006/diff/10001/runtime/vm/assembler_arm.cc#newcode1954 runtime/vm/assembler_arm.cc:1954: vmovsr(STMP, left); On 2013/07/01 16:54:09, regis wrote: > ...

7 years, 5 months ago (2013-07-01 17:43:46 UTC) #3

zra

7 years, 5 months ago (2013-07-01 17:44:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r24635 (presubmit successful).

Expand Messages | Collapse Messages