- Actually allocate memory.

- Actually allocate memory.

Committed: https://code.google.com/p/dart/source/detail?r=33112

[Ivan Posva, 2014-02-27 09:57:49]

Committed patchset #1 manually as r33112.

[Florian Schneider, 2014-02-27 10:03:22]

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc
File runtime/vm/cpuid.cc (right):

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc#newcode54
runtime/vm/cpuid.cc:54: reinterpret_cast<char*>(malloc(3 * 4 *
sizeof(uint32_t)));
If you use new char[] and delete[] instead of malloc/free, this should avoid the
ugly casts.

[Ivan Posva, 2014-02-27 10:13:41]

-Ivan

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc
File runtime/vm/cpuid.cc (right):

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc#newcode54
runtime/vm/cpuid.cc:54: reinterpret_cast<char*>(malloc(3 * 4 *
sizeof(uint32_t)));
On 2014/02/27 10:03:22, Florian Schneider wrote:
> If you use new char[] and delete[] instead of malloc/free, this should avoid
the
> ugly casts.

Thank you for your insight. But the whole point of these changes was avoiding
the mix of new char[], strdup (aka malloc) and delete[] since some allocators to
not appreciate that and will fail you at runtime.

[Florian Schneider, 2014-02-27 10:21:28]

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc
File runtime/vm/cpuid.cc (right):

https://codereview.chromium.org/182943002/diff/1/runtime/vm/cpuid.cc#newcode54
runtime/vm/cpuid.cc:54: reinterpret_cast<char*>(malloc(3 * 4 *
sizeof(uint32_t)));
On 2014/02/27 10:13:41, Ivan Posva wrote:
> On 2014/02/27 10:03:22, Florian Schneider wrote:
> > If you use new char[] and delete[] instead of malloc/free, this should avoid
> the
> > ugly casts.
> 
> Thank you for your insight. But the whole point of these changes was avoiding
> the mix of new char[], strdup (aka malloc) and delete[] since some allocators
to
> not appreciate that and will fail you at runtime.

Why use strdup then? I thought the point of returning a const char* is that the
string can't be changed by the caller - unless with a cast ofc.