- Actually allocate memory.

runtime/vm/cpuid.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if !defined(TARGET_OS_MACOS)
 #include "vm/cpuid.h"
 
 #if defined(HOST_ARCH_IA32) || defined(HOST_ARCH_X64)
 // GetCpuId() on Windows, __get_cpuid() on Linux
@@ skipping 32 matching lines @@
   // Yes, these are supposed to be out of order.
   *reinterpret_cast<uint32_t*>(id_string) = info[1];
   *reinterpret_cast<uint32_t*>(id_string + 4) = info[3];
   *reinterpret_cast<uint32_t*>(id_string + 8) = info[2];
   CpuId::id_string_ = id_string;
 
   GetCpuId(1, info);
   CpuId::sse41_ = (info[2] & (1 << 19)) != 0;
   CpuId::sse2_ = (info[3] & (1 << 26)) != 0;
 
-  char* brand_string = reinterpret_cast<char*>(3 * 4 * sizeof(uint32_t));
+  char* brand_string =
+      reinterpret_cast<char*>(malloc(3 * 4 * sizeof(uint32_t)));

[Florian Schneider, 2014/02/27 10:03:22]

If you use new char[] and delete[] instead of malloc/free, this should avoid the
ugly casts.

[Ivan Posva, 2014/02/27 10:13:41]

Thank you for your insight. But the whole point of these changes was avoiding
the mix of new char[], strdup (aka malloc) and delete[] since some allocators to
not appreciate that and will fail you at runtime.

[Florian Schneider, 2014/02/27 10:21:29]

Why use strdup then? I thought the point of returning a const char* is that the
string can't be changed by the caller - unless with a cast ofc.

   for (uint32_t i = 0x80000002; i <= 0x80000004; i++) {
     uint32_t off = (i - 0x80000002U) * 4 * sizeof(uint32_t);
     GetCpuId(i, info);
     *reinterpret_cast<int32_t*>(brand_string + off) = info[0];
     *reinterpret_cast<int32_t*>(brand_string + off + 4) = info[1];
     *reinterpret_cast<int32_t*>(brand_string + off + 8) = info[2];
     *reinterpret_cast<int32_t*>(brand_string + off + 12) = info[3];
   }
   CpuId::brand_string_ = brand_string;
 }
@@ skipping 43 matching lines @@
       UNREACHABLE();
       return NULL;
     }
   }
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
 }  // namespace dart
 
 #endif  // !defined(TARGET_OS_MACOS)