Issue 18282008: Revert "Move toString() to collection classes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18282008: Revert "Move toString() to collection classes." (Closed)

Created:
7 years, 5 months ago by zarah

Modified:
7 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Move toString() to collection classes." This reverts commit 24836 Committed: https://code.google.com/p/dart/source/detail?r=24837

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -196 lines)			Patch
M	runtime/lib/array.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/typed_data.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_collection_dev/iterable.dart	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_array.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/collection/linked_list.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/collection/list.dart	View	2 chunks	+1 line, -21 lines	0 comments	Download
M	sdk/lib/collection/maps.dart	View	2 chunks	+1 line, -30 lines	0 comments	Download
M	sdk/lib/collection/queue.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download
D	tests/corelib/list_to_string2_test.dart	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	tests/corelib/map_to_string_test.dart	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	tests/corelib/set_to_string_test.dart	View	1 chunk	+0 lines, -37 lines	0 comments	Download

Total messages: 3 (0 generated)

zarah

Committed patchset #1 manually as r24837 (presubmit successful).

7 years, 5 months ago (2013-07-09 09:36:58 UTC) #2

Message was sent while issue was closed.

LGTM.